fix: Max balance for dApp erc20 approval

[pedronfigueiredo]

Description

When the user clicks "Max" on ERC20 token approvals, the account token balance is set as the spending cap. However, this number is rounded to 5 decimals places, which sometimes results in a value smaller than the actual token balance.

This PR fixes this bug by setting the unrounded account token balance instead.

Related issues

Fixes: #13122

Manual testing steps

1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[github-actions]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: ed9a2e3
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/1acbcf0f-3f53-4063-8491-7f61862c7cd5

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
55.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[github-actions]

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 8527fc0
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f8a5224d-ff56-4f0d-9b36-577449d68feb

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

• Check the documentation if you have any doubts on how to understand the failure on bitrise

[digiwand]

added a suggestion to remove conditional

It could also be helpful to add tests to check the full balance is shown

[digiwand]

Suggested change

	if (maxSelected) setValue(unroundedAccountBalance || accountBalance);
	}, [maxSelected, accountBalance, unroundedAccountBalance]);
	if (maxSelected) setValue(unroundedAccountBalance);
	}, [maxSelected, unroundedAccountBalance]);

I think we may no longer need accountBalance. Else I think since unroundedAccountBalance may be an empty string, || accountBalance may never be reached