Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✏️ Fix wrong example snippet for M109 #592

Merged

Conversation

antedeguemon
Copy link
Contributor

@antedeguemon antedeguemon commented Mar 1, 2025

Hey there! 🖖

The M109 gcode documentation states:

[R<temp>]
Target temperature (wait for cooling or heating).

[S<temp>]
Target temperature (wait only when heating).

But there is an example on the same page where it says the R will wait if heating up, not mentioning the or cooling part of the conditional:

Set target temperature for E1 and wait (if heating up)
M109 T1 R205

I believe S<temp> was meant instead of R<temp>, or the or cooling part was forgotten. This pull request assumes the first scenario and replaces S<temp> ➡️ R<temp>.

@thinkyhead thinkyhead merged commit 93526be into MarlinFirmware:master Mar 5, 2025
1 check passed
@thinkyhead
Copy link
Member

Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants