Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching toolhead array access protection #23985

Merged
merged 3 commits into from
Apr 3, 2022
Merged

Switching toolhead array access protection #23985

merged 3 commits into from
Apr 3, 2022

Conversation

GMagician
Copy link
Contributor

Should fix #23980

@GMagician
Copy link
Contributor Author

GMagician commented Apr 2, 2022

Can't find out which cnf is used to see why it doesn't compile

@ellensp
Copy link
Contributor

ellensp commented Apr 3, 2022

In buildroot/tests/BIGTREE_GTR_V1_0

It uses the bugfix default config then modifies it with

restore_configs
opt_set MOTHERBOARD BOARD_BTT_GTR_V1_0 SERIAL_PORT -1 \
        EXTRUDERS 3 TEMP_SENSOR_1 1 TEMP_SENSOR_2 1 \
        SERVO_DELAY '{ 300, 300, 300 }'
opt_enable SWITCHING_TOOLHEAD TOOL_SENSOR
exec_test $1 $2 "BigTreeTech GTR | Switching Toolhead | Tool Sensors" "$3"

so it probably needs a SWITCHING_TOOLHEAD_X_POS '{ 215, 0 ,0}' added to opt_set

Copy link
Contributor

@ellensp ellensp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a \ on end of the previous line. the opt_set is one line split over several actual lines

@GMagician
Copy link
Contributor Author

Yep, just made quickly and not take too much care of what I've done. Thanks for note

@thinkyhead thinkyhead merged commit 591fa8b into MarlinFirmware:bugfix-2.0.x Apr 3, 2022
@GMagician GMagician deleted the sanity-check branch April 4, 2022 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants