Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multiple errors in the _final_aggregation function for PearsonCorrCoef #2980

Merged
merged 4 commits into from
Feb 28, 2025

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented Feb 28, 2025

What does this PR do?

Fixes #2893

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--2980.org.readthedocs.build/en/2980/

@SkafteNicki SkafteNicki added the bug / fix Something isn't working label Feb 28, 2025
@SkafteNicki SkafteNicki added this to the v1.5.x milestone Feb 28, 2025
Copy link

codecov bot commented Feb 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36%. Comparing base (5f675f4) to head (c40b68a).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #2980     +/-   ##
========================================
- Coverage      70%     36%    -34%     
========================================
  Files         350     350             
  Lines       19539   19532      -7     
========================================
- Hits        13668    7027   -6641     
- Misses       5871   12505   +6634     

@SkafteNicki SkafteNicki self-assigned this Feb 28, 2025
@SkafteNicki SkafteNicki modified the milestones: v1.5.x, v1.6.x Feb 28, 2025
@Borda Borda merged commit abf1708 into master Feb 28, 2025
60 checks passed
@Borda Borda deleted the bugfix/pearson2 branch February 28, 2025 14:03
@mergify mergify bot added the ready label Feb 28, 2025
Borda pushed a commit that referenced this pull request Feb 28, 2025
…CorrCoef` (#2980)

* fix src
* add tests
* changelog

(cherry picked from commit abf1708)
Borda pushed a commit that referenced this pull request Mar 3, 2025
…CorrCoef` (#2980)

* fix src
* add tests
* changelog

(cherry picked from commit abf1708)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pearson _final_aggregation modifies states in place (+ link out of date)
2 participants