Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PublishWithi18nAction interprets validation Warnings as Errors #58

Closed
daniel-akerman-eqtpartners opened this issue Jun 29, 2021 · 0 comments
Closed

PublishWithi18nAction interprets validation Warnings as Errors #58

daniel-akerman-eqtpartners opened this issue Jun 29, 2021 · 0 comments

Comments

@daniel-akerman-eqtpartners
Copy link

This is related to the fix of this issue
#46

Now warnings will be interpreted as errors which is not the default behaviour of Sanity. Instead of just looking at the marker I suggest adding a check to see if it's actually a error

markers.some(marker => marker.level === 'error')
@daniel-akerman-eqtpartners daniel-akerman-eqtpartners changed the title PublishWithi18nAction interprets validation Warnings as errors PublishWithi18nAction interprets validation Warnings as Errors Jun 29, 2021
LiamMartens added a commit that referenced this issue Jun 30, 2021
@LiamMartens
fix: Fixes #58
0277fbe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@daniel-akerman-eqtpartners