Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ’š (commits) [NO-ISSUE]: Fix creation of branch before using gh api #715

Merged
merged 1 commit into from
Mar 10, 2025

Conversation

valpinkman
Copy link
Member

πŸ“ Description

Create upstream branch before using github api to create commit

❓ Context

  • JIRA or GitHub link: [NO-ISSUE]
  • Feature:

βœ… Checklist

Pull Requests must pass CI checks and undergo code review. Set the PR as Draft if it is not yet ready for review.

  • Covered by automatic tests
  • Changeset is provided
  • Impact of the changes:
    • list of the changes

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.

@Copilot Copilot bot review requested due to automatic review settings March 10, 2025 09:51
@valpinkman valpinkman requested a review from a team as a code owner March 10, 2025 09:51
Copy link

vercel bot commented Mar 10, 2025

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
device-sdk-ts-sample βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Mar 10, 2025 9:53am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
doc-device-management-kit ⬜️ Ignored (Inspect) Visit Preview Mar 10, 2025 9:53am

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This pull request fixes an issue with branch creation in the GitHub Actions workflow by ensuring that the upstream branch is properly set before using the GitHub API to create a commit.

  • Added a git push command with the --set-upstream flag to create the upstream branch.
  • Updated the workflow configuration to reflect this change.

Reviewed Changes

File Description
.github/workflows/update_toolchain.yml Added a push command to set the upstream branch after checkout

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Copy link
Contributor

Messages
⚠️ No changeset file found. Please make sure this is intended or add a changeset file.

Generated by 🚫 dangerJS against 0544bc4

@valpinkman valpinkman added this pull request to the merge queue Mar 10, 2025
Merged via the queue into develop with commit 01cba17 Mar 10, 2025
15 of 16 checks passed
@valpinkman valpinkman deleted the chore/no-issue-fix-signing-commits branch March 10, 2025 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants