Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review and write unit tests for bolt policy checks #16

Merged
merged 1 commit into from
Feb 19, 2022
Merged

Review and write unit tests for bolt policy checks #16

merged 1 commit into from
Feb 19, 2022

Conversation

grunch
Copy link
Contributor

@grunch grunch commented Feb 7, 2022 •
edited
Loading

  • Add some unit tests to check bolt 2 policies.
  • Corrects some values on the default policies on lnd, eclair and c-lightning.
  • Implement dumb_default() method to AcceptChannel message

Fix #13

@codecov
Copy link

codecov bot commented Feb 7, 2022 •
edited
Loading

Codecov Report

Merging #16 (58ba52b) into master (238abbb) will increase coverage by 1.3%.
The diff coverage is 92.3%.

❗ Current head 58ba52b differs from pull request most recent head 6e5c3eb. Consider uploading reports for the commit 6e5c3eb to get more accurate results

Impacted file tree graph

@@           Coverage Diff            @@
##           master     #16     +/-   ##
========================================
+ Coverage    36.4%   37.7%   +1.3%     
========================================
  Files          20      20             
  Lines        1744    1757     +13     
========================================
+ Hits          634     662     +28     
+ Misses       1110    1095     -15
Impacted Files Coverage Δ
lnp2p/src/legacy/bolt2.rs 9.9% <92.3%> (+9.9%) ⬆️
lnp2p/src/legacy/types.rs 55.6% <0.0%> (+0.7%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 238abbb...6e5c3eb. Read the comment docs.

@grunch
Add unit tests to check that the policies work
6e5c3eb 
* Add some unit tests to check bolt
* Corrects some values on the default policies on lnd, eclair and c-lightning.
* Implement dumb_default() method to AcceptChannel message
@grunch grunch force-pushed the issue_13-Review-and-write-unit-tests-for-BOLT-policy-checks branch from 58ba52b to 6e5c3eb Compare February 8, 2022 00:04
dr-orlovsky
dr-orlovsky approved these changes Feb 19, 2022
View reviewed changes
Copy link
Contributor

@dr-orlovsky dr-orlovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 6e5c3eb

Sorry for the late review, was ill for last days and felt really bad

@dr-orlovsky dr-orlovsky merged commit 9e235c0 into LNP-WG:master Feb 19, 2022
@dr-orlovsky dr-orlovsky added this to the v0.9.0 milestone Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dr-orlovsky dr-orlovsky dr-orlovsky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.9.0
Development

Successfully merging this pull request may close these issues.

Review and write unit tests for BOLT policy checks
2 participants
@grunch @dr-orlovsky