Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fix_chart_line): set to chart line default color #834

Merged
merged 10 commits into from
Apr 20, 2021
Merged

Conversation

ssakone
Copy link

@ssakone ssakone commented Apr 20, 2021

No description provided.

@ssakone ssakone requested review from Milerius and tonymorony April 20, 2021 05:21
@tonymorony
Copy link

image

the dot does not on the graph mostly - could you please try to fix that?

Screenshot 2021-04-20 at 15 33 05

also, grey axes labels (numbers and dates) not well visible on a dark background - could you please try to make it white and in white theme keep it the same color as now?

@ssakone
Copy link
Author

ssakone commented Apr 20, 2021

ok

image

the dot does not on the graph mostly - could you please try to fix that?

Screenshot 2021-04-20 at 15 33 05

also, grey axes labels (numbers and dates) not well visible on a dark background - could you please try to make it white and in white theme keep it the same color as now?

ok

@smk762
Copy link
Collaborator

smk762 commented Apr 20, 2021

also noticed some weirdness with the dot and date. dot seems to drop below line on todays date, and tooltip date reverts to jan1 outside chart

chart_date_wierd.mp4

Changing to 7D or 1M on chart there is a bit of a delay before it shows the loading dots

chart_load_indicate_slow.mp4

Any chance we can get the % back after the numeric values?
image

@tonymorony tonymorony mentioned this pull request Apr 20, 2021
@smk762
Copy link
Collaborator

smk762 commented Apr 20, 2021

found some value overflow when in minimized mode with a large balance on dex screen
image

@tonymorony
Copy link

found some value overflow when in minimized mode with a large balance on dex screen
image

good catch, @smk762 could you please create a separate issue for this one?

@tonymorony
Copy link

outstanding things related to the graph at the moment [ CC @ssakone ]:

  1. values pointing not limited on the left edge

Screenshot 2021-04-20 at 22 13 22

  1. would be great to ensure that vertical line is inside the graph borders:

Screenshot 2021-04-20 at 22 15 47

@ssakone
Copy link
Author

ssakone commented Apr 20, 2021

ok

@Milerius Milerius merged commit 9f01c07 into dev Apr 20, 2021
@Milerius Milerius deleted the fix_chart_line branch April 20, 2021 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants