Make document tabs closable #240
Conversation
There was a problem hiding this comment.
I didn't do that because I find it very ugly... (I already refused such a PR).
The only way for me to accept would be to change the style of the close button, like VS Code for example:
- only show the button on the current tab
- or when hovering the other tabs
- change the icon to use the close icon from the dock for example
I don't think it's worth it. If you want to do it, go ahead, otherwise close the PR.
Cuperino
force-pushed
the
closable-tabs
branch
2 times, most recently
from
b3ab264 to
ad0bbd3
Compare
This sounds more like a theming and Qt design issue... This what the buttons look like in KDE Plasma's Breeze dark theme:
I tried going with your first option, for I think that is the best possible solution. However, tabList is stored in the Having all tabs appear and disappear at the simultaneously can be jarring if it happens consecutively too quickly, so I also added a timer before the buttons are hidden again. For the delay I chose 2 seconds, which is what is used for a "human moment" over at KDE. It's important for users to have an intuitive and efficient way to close tabs with the mouse cursor. I also thought about closing a tab with a middle click, but that wouldn't have been as intuitive as having a close button in the tab. |
This implementation shows and hides all close buttons simultaneously while mouse cursor hovers over them. A delay was added before close buttons are hidden again to save the user from a jarring experience when they off-shoot the mouse cursor reaching for the tab bar. Ideally we'd only display close buttons for the active tab and the tab currently being hovered. However, the list of tabs is stored in the protected side of QTabBar (qtabbar_p.h) and we can't make use of it without re-inventing the wheel.
Allow closing documents by clicking X in their tabs.