GH Actions: remove event_name from job name #487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems unnecessary as the event is already shown in parantheses alongside the job name. Having this in the job name causes issues when using a merge queue as GitHub expects required jobs to have the same name irrespective of being triggered by push/pr or by merge queue
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #487 +/- ##
=======================================
Coverage 94.33% 94.33%
=======================================
Files 24 24
Lines 742 742
=======================================
Hits 700 700
Misses 42 42 ☔ View full report in Codecov by Sentry. |
oxinabox
approved these changes
Nov 12, 2024
simeonschaub
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems unnecessary as the event is already shown in parantheses
alongside the job name. Having this in the job name causes issues when
using a merge queue as GitHub expects required jobs to have the same
name irrespective of being triggered by push/pr or by merge queue