-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Actually apply the GNU licenses #447
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #447 +/- ##
=======================================
Coverage 92.95% 92.95%
=======================================
Files 24 24
Lines 738 738
=======================================
Hits 686 686
Misses 52 52 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks, could you just add a link to the PR conversation to show where you took the recommended verbiage from?
For GPL-3.0+ I got the text from PkgTemplates.jl/templates/licenses/GPL-3.0+ Lines 635 to 648 in 46997ed
For GPL-2.0+ I got the text from PkgTemplates.jl/templates/licenses/GPL-2.0+ Lines 294 to 308 in 46997ed
For LGPL-3.0+ I got the text from PkgTemplates.jl/templates/licenses/GPL-3.0+ Lines 635 to 648 in 46997ed
For LGPL-2.1+ I got the text from PkgTemplates.jl/templates/licenses/LGPL-2.1+ Lines 474 to 489 in 46997ed
For AGPL3.0+ I got the text from PkgTemplates.jl/templates/licenses/AGPL-3.0+ Lines 633 to 646 in 46997ed
|
Thanks! |
The GNU licenses contain instructions for applying those licenses to works. They say that, ideally, folks should add a notice to each file. However, the template as was did not actually state that the works are licensed under the included license. This PR changes that by copying the recommended verbiage from each respective license.