Move some of Backend and DAO requests to a DOTNET server #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulhands
commented
Apr 26, 2018
paulhands
commented
- Still a WIP so should be merged to a different branch but would like it to be on the main repo so someone else can pick up when I get off the bench
- Need to sort out heroku / docker image issues.
- Need to sort out config variables like slack token etc.
- Need to investigate capacity for slack integration (websockets) and LUIS dialog integration
- Client side requests now route through the dotnet server (ran locally) - Will need to change heroku access port in future PR - Current plan is to have dotnet server be the only way of accessing DB - Slackbot tools on client can probably stay but need tidying up - Server tests need adding
Added new dotnet server to integrate with the database
- after PR comments removed usings that were around from debugging - Also explicitly declared types where possible
- .NET core does not support websockets. So current plan is to move as much logic into the server as possible (for writing/posting messages, receiving queries etc.) but keeping the listeners on the client side of the server
Further modifications to server, remove database dependency from client
- these will need adding as heroku variables and the files tweaking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.