Context Actions: support named patterns annotation #783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DedSec256
changed the title
DedSec256
force-pushed
the
ber.a/patternAnnot
branch
from
48ad561 to
4b4ae9d
Compare
auduchinok
reviewed
Feb 13, 2025
| @@ -19,3 +21,8 @@ let getFunctionTypeArgs includeReturnType fcsType = | |||
| acc | |||
|
|
|||
| loop fcsType [] |> List.rev | |||
|
|
|||
| let fixIfOptionalParameter (pattern: IReferencePat) fcsType = | |||
There was a problem hiding this comment.
What does fix mean here?
What does it return? And what happens if the parameter is not optional?
|
|
||
|
|
||
| [<ContextAction(Name = "AnnotatePattern", GroupType = typeof<FSharpContextActions>, | ||
| Description = "Annotate named pattern")>] |
There was a problem hiding this comment.
Do we only want to work it for named patterns?
There was a problem hiding this comment.
In this PR, I would focus on named patterns (for example, we now show inlay hints mainly for named patterns)
| @@ -50,7 +50,12 @@ module SpecifyTypes = | |||
| parenPat.SetPattern(pattern) |> ignore | |||
| parenPat :> IFSharpPattern | |||
|
|
|||
| let specifyParameterType displayContext (fcsType: FSharpType) (pattern: IFSharpPattern) = | |||
| let specifyPattern displayContext (fcsType: FSharpType) (pattern: IFSharpPattern) = | |||
There was a problem hiding this comment.
What does 'specify pattern' mean?
DedSec256
force-pushed
the
ber.a/patternAnnot
branch
from
d5d6089 to
cc0e5ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.