Fixed highlighting for xint literals with separators #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auduchinok
reviewed
Jan 13, 2023
There was a problem hiding this comment.
@En3Tho This is a very nice fix, thank you!
Could you also cover multiple underscores in a row in the lexer tests and add the new lexer tests to FSharpLexerTest in the frontend plugin?
|
@auduchinok Sure. For FSharpLexerTest - do you mean that instead of adding those to testDigit I should create another test specifically for underscores or should I just add multiple underscore cases in addition to single ones that I've already added? |
|
Sorry, I have somehow missed it was already there! Thanks for adding it! |
auduchinok
approved these changes
Jan 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes lexer a little bit to properly highlight numbers with prefix and separators like
Before: highlighted as text
After: highlighted as number