-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automate representation test overwrite #550
Merged
eupp
merged 9 commits into
develop
from
bbrockbernd/automate-representation-test-overwrite
Feb 28, 2025
Merged
Automate representation test overwrite #550
eupp
merged 9 commits into
develop
from
bbrockbernd/automate-representation-test-overwrite
Feb 28, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0ae0361
to
0d79de2
Compare
eupp
requested changes
Feb 27, 2025
src/jvm/test/org/jetbrains/kotlinx/lincheck_test/util/TestUtils.kt
Outdated
Show resolved
Hide resolved
src/jvm/test/org/jetbrains/kotlinx/lincheck_test/util/TestUtils.kt
Outdated
Show resolved
Hide resolved
src/jvm/test/org/jetbrains/kotlinx/lincheck_test/util/TestUtils.kt
Outdated
Show resolved
Hide resolved
eupp
approved these changes
Feb 27, 2025
5d015bb
to
ab74205
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two problems when working on trace representation.
expectedOutputFilePrefix
. The result of this is that a lot of test files changed.How it works:
The test outputs of the run with jdk 8 and non trace mode, are considered as the base output and will therefore always (over)write the txt. If a test is run with a higher jdk and/or in trace mode. We will look if a txt for that combo exists and if not we will look at lower jdks (and at the non-trace side). We will then compare the output to the found file. If it differs we (over)write the file with current jdk and mode.