Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate representation test overwrite #550

Merged
merged 9 commits into from
Feb 28, 2025

Conversation

bbrockbernd
Copy link
Collaborator

This PR fixes two problems when working on trace representation.

  • It provides a script that runs all tests on all relevant jdks on all modes (trace debugger and non trace debugger)
  • It auto generates txt output files for new tests, only for jdks and modes where the outputs differ (to prevent duplication)
  • Since it generates the txt files necessary, we only provide a expectedOutputFilePrefix. The result of this is that a lot of test files changed.
  • Since most test files changed (in line numbers) the output txts changed as well.
  • Additionally, since it chooses when a seperate txt file for a test is needed, some txts are gone and others have been added.

How it works:
The test outputs of the run with jdk 8 and non trace mode, are considered as the base output and will therefore always (over)write the txt. If a test is run with a higher jdk and/or in trace mode. We will look if a txt for that combo exists and if not we will look at lower jdks (and at the non-trace side). We will then compare the output to the found file. If it differs we (over)write the file with current jdk and mode.

@bbrockbernd bbrockbernd requested a review from eupp February 26, 2025 18:53
@bbrockbernd bbrockbernd changed the title Bbrockbernd/automate representation test overwrite Automate representation test overwrite Feb 27, 2025
@bbrockbernd bbrockbernd force-pushed the bbrockbernd/automate-representation-test-overwrite branch from 0ae0361 to 0d79de2 Compare February 27, 2025 08:39
@bbrockbernd bbrockbernd requested a review from eupp February 27, 2025 12:34
@eupp eupp force-pushed the bbrockbernd/automate-representation-test-overwrite branch from 5d015bb to ab74205 Compare February 27, 2025 22:08
@eupp eupp merged commit f0b6b22 into develop Feb 28, 2025
20 checks passed
@eupp eupp deleted the bbrockbernd/automate-representation-test-overwrite branch February 28, 2025 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants