Allow loop detector replayer to continue executing after it finished the replayed part #524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eeds the replayed interleaving Signed-off-by: Evgeniy Moiseenko <[email protected]>
Signed-off-by: Evgeniy Moiseenko <[email protected]>
Signed-off-by: Evgeniy Moiseenko <[email protected]>
Signed-off-by: Evgeniy Moiseenko <[email protected]>
dmitrii-artuhov
requested changes
Feb 17, 2025
src/jvm/main/org/jetbrains/kotlinx/lincheck/strategy/managed/LoopDetector.kt
Outdated
Show resolved
Hide resolved
Comment on lines
+258
to
+259
| // Unexpected `ThreadAbortedError` should be thrown. | ||
| check(result is UnexpectedExceptionInvocationResult) |
There was a problem hiding this comment.
Is transferring this check below a necessary change?
There was a problem hiding this comment.
Yes it was on purpose. Looks like there could be cases when suddenResult is SpinCycleFoundAndReplayRequired, but result !is UnexpectedExceptionInvocationResult.
There was a problem hiding this comment.
Could such case be added as a test then?
There was a problem hiding this comment.
I am going to add a test with coroutines under #505, which fails because of this. But I haven't try to minimize it, because the execution trace is quite large in this test, and I cannot easily find a place that exactly triggers this problem.
Signed-off-by: Evgeniy Moiseenko <[email protected]>
dmitrii-artuhov
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of #505