Non-determinism fix: ClassLoaders are now transformed in the Model Checking mode #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndkoval
requested changes
Oct 8, 2024
There was a problem hiding this comment.
Hi, @avpotapov00, thanks for the fix!
Could you please add a simple test that reveals the bug and measure the performance impact of this change? Intuitively, when running a single test, re-instrumenting all classes with ClassLoader in their names can increase the running time by several seconds.
src/jvm/test/org/jetbrains/kotlinx/lincheck_test/transformation/channel/ChannelSegment.kt
Outdated
Show resolved
Hide resolved
src/jvm/test/org/jetbrains/kotlinx/lincheck_test/transformation/channel/BufferedChannel.kt
Outdated
Show resolved
Hide resolved
src/jvm/test/org/jetbrains/kotlinx/lincheck_test/transformation/channel/BufferedChannelTest.kt
Outdated
Show resolved
Hide resolved
src/jvm/test/org/jetbrains/kotlinx/lincheck_test/transformation/channel/BufferedChannelTest.kt
Outdated
Show resolved
Hide resolved
|
Also, we can slightly improve the running time of small tests by re-instrumenting only those classes with |
Merged
ndkoval
requested changes
Oct 15, 2024
src/jvm/main/org/jetbrains/kotlinx/lincheck/transformation/LincheckJavaAgent.kt
Outdated
Show resolved
Hide resolved
src/jvm/main/org/jetbrains/kotlinx/lincheck/transformation/TransformationUtils.kt
Outdated
Show resolved
Hide resolved
src/jvm/test/org/jetbrains/kotlinx/lincheck_test/transformation/channel/BufferedChannelTest.kt
Outdated
Show resolved
Hide resolved
src/jvm/test/org/jetbrains/kotlinx/lincheck_test/transformation/channel/BufferedChannelTest.kt
Outdated
Show resolved
Hide resolved
ndkoval
changed the title
eupp
reviewed
Oct 17, 2024
src/jvm/main/org/jetbrains/kotlinx/lincheck/transformation/LincheckJavaAgent.kt
Show resolved
Hide resolved
ndkoval
reviewed
Oct 17, 2024
src/jvm/main/org/jetbrains/kotlinx/lincheck/transformation/LincheckJavaAgent.kt
Show resolved
Hide resolved
ndkoval
reviewed
Oct 17, 2024
.../test/org/jetbrains/kotlinx/lincheck_test/transformation/channel/IncorrectBufferedChannel.kt
Outdated
Show resolved
Hide resolved
ndkoval
requested changes
Oct 17, 2024
...tbrains/kotlinx/lincheck_test/verifier/linearizability/IncorrectBufferedChannelCustomTest.kt
Outdated
Show resolved
Hide resolved
ndkoval
approved these changes
Oct 17, 2024
ndkoval
deleted the
412-classloaders-are-not-transformed-in-modelchecking-mode
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #412, #377, #405