Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove fillMax* from Divider to avoid glitches and edge-cases #699

Merged
merged 2 commits into from
Nov 25, 2024
Merged

Remove fillMax* from Divider to avoid glitches and edge-cases #699

merged 2 commits into from
Nov 25, 2024

Conversation

hamen
Copy link
Collaborator

@hamen hamen commented Nov 25, 2024

Closes #696

@hamen hamen self-assigned this Nov 25, 2024
@hamen hamen requested a review from rock3r November 25, 2024 11:15
@hamen hamen added the maintenance Rote maintenance tasks (e.g., dependency updates) label Nov 25, 2024
rock3r
rock3r approved these changes Nov 25, 2024
View reviewed changes
Copy link
Collaborator

@rock3r rock3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! We need to remember putting this in the release notes as a breaking change

@rock3r rock3r enabled auto-merge (squash) November 25, 2024 11:21
@rock3r rock3r merged commit 54397bd into main Nov 25, 2024
1 check passed
@rock3r rock3r deleted the im-969-iterate-on-devider branch November 25, 2024 12:14
rock3r added a commit that referenced this pull request Nov 25, 2024
@rock3r
Fix Dividers after #699 was merged
74e74c6
@rock3r rock3r mentioned this pull request Nov 25, 2024
Merged
rock3r added a commit that referenced this pull request Nov 25, 2024
@rock3r
Fixup after dividers (#700)
0b5c26d 
* Fix Dividers after #699 was merged

* Fix thematic breaks rendering in Markdown

* Fix dropdown in Markdown sample

It was very™ broken

* Cleanup
@rock3r rock3r mentioned this pull request Nov 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rock3r rock3r rock3r approved these changes

Assignees

@hamen hamen

Labels
maintenance Rote maintenance tasks (e.g., dependency updates)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove fillMax* from Divider
2 participants
@hamen @rock3r