Improve string-based Icon deprecation #555
Conversation
|
|
||
| object IdeSampleIconKeys { | ||
| val gitHub = IntelliJIconKey("icons/github.svg", "icons/github.svg", IdeSampleIconKeys::class.java) | ||
| val gitHub = PathIconKey("icons/github.svg", IdeSampleIconKeys::class.java) |
There was a problem hiding this comment.
We don't have NewUI mappings for these, so a simple PathIconKey is enough
There was a problem hiding this comment.
Nice. Yesterday, I replaced another icon on one of my branches and I created like the gitHub one you are improving. Gotta improve mine as well 🙏🏻
| @@ -42,7 +42,11 @@ import java.io.InputStream | |||
|
|
|||
| @Deprecated( | |||
| "Use the IconKey-based API instead", | |||
| ReplaceWith("Icon(PathIconKey(resource, iconClass), contentDescription, colorFilter, modifier, hints)"), | |||
| ReplaceWith( | |||
There was a problem hiding this comment.
Param names are necessary for the resulting code to compile, especially with the vararg versions.
There was a problem hiding this comment.
💯 It saves a bit of time. I was manually adding the names and then running the ReplaceWith.
Adding the PathIconKey import and param names to the ReplaceWith makes the auto-upgrade seamless. It would result in red code otherwise. Upgrade Icon in SwingComparisonTabPanel to new style.
rock3r
force-pushed
the
improve-icon-deprecation
branch
from
236c494 to
c862348
Compare
|
|
||
| object IdeSampleIconKeys { | ||
| val gitHub = IntelliJIconKey("icons/github.svg", "icons/github.svg", IdeSampleIconKeys::class.java) | ||
| val gitHub = PathIconKey("icons/github.svg", IdeSampleIconKeys::class.java) |
There was a problem hiding this comment.
Nice. Yesterday, I replaced another icon on one of my branches and I created like the gitHub one you are improving. Gotta improve mine as well 🙏🏻
| @@ -42,7 +42,11 @@ import java.io.InputStream | |||
|
|
|||
| @Deprecated( | |||
| "Use the IconKey-based API instead", | |||
| ReplaceWith("Icon(PathIconKey(resource, iconClass), contentDescription, colorFilter, modifier, hints)"), | |||
| ReplaceWith( | |||
There was a problem hiding this comment.
💯 It saves a bit of time. I was manually adding the names and then running the ReplaceWith.
Adding the PathIconKey import and param names to the ReplaceWith makes the auto-upgrade seamless. It would result in red code otherwise.
Upgrade Icon in SwingComparisonTabPanel to new style.