Only process each buildscript once in JavaGradleProjectResolver #2983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nskvortsov
requested changes
Mar 7, 2025
| @@ -50,6 +50,9 @@ | |||
| @Order(ExternalSystemConstants.UNORDERED) | |||
| public final class JavaGradleProjectResolver extends AbstractProjectResolverExtension { | |||
|
|
|||
| private final IdentityHashMap<GradleBuildScriptClasspathModel, List<BuildScriptClasspathData.ClasspathEntry>> buildScriptEntriesMap = | |||
There was a problem hiding this comment.
I am confused by the explicit usage of IdentityHashMap here. Are the instances of GradleBuildScriptClasspathModel internalized?
There was a problem hiding this comment.
Similarly, it was my experience that they were always the same, but I don't fully understand why. I can dig deeper to understand.
| @@ -50,6 +50,9 @@ | |||
| @Order(ExternalSystemConstants.UNORDERED) | |||
| public final class JavaGradleProjectResolver extends AbstractProjectResolverExtension { | |||
|
|
|||
| private final IdentityHashMap<GradleBuildScriptClasspathModel, List<BuildScriptClasspathData.ClasspathEntry>> buildScriptEntriesMap = | |||
There was a problem hiding this comment.
Storing state here will cause memory leak, as this class is a long-living service. It is not re-created on each sync.
There was a problem hiding this comment.
I will apply your suggestion from the other PR here too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should improve import performance for large projects