-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JEWEL-765] Iterate on Tree a11y #2976
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice changes! I have a couple of suggestions to improve it further.
...m/jewel/foundation/src/main/kotlin/org/jetbrains/jewel/foundation/lazy/tree/BasicLazyTree.kt
Show resolved
Hide resolved
...form/jewel/foundation/src/main/kotlin/org/jetbrains/jewel/foundation/lazy/tree/KeyActions.kt
Show resolved
Hide resolved
if (element is Tree.Element.Node) { | ||
append(if (element.id in treeState.openNodes) "expanded " else "collapsed ") | ||
} | ||
append(element.data?.toString() ?: "") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm also not sure if this line is needed. I checked the properties in the access bridge explorer, and it looks like the text on the node can be set to both name and description, and it's causing it to be read twice. In IntelliJ it's only set to the name:
https://youtrack.jetbrains.com/issue/JEWEL-765/a11y-Tree