Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JEWEL-765] Iterate on Tree a11y #2976

Draft
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

hamen
Copy link
Collaborator

@hamen hamen commented Mar 3, 2025

Copy link
Member

@dmitrii-drobotov dmitrii-drobotov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice changes! I have a couple of suggestions to improve it further.

@hamen hamen self-assigned this Mar 7, 2025
if (element is Tree.Element.Node) {
append(if (element.id in treeState.openNodes) "expanded " else "collapsed ")
}
append(element.data?.toString() ?: "")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm also not sure if this line is needed. I checked the properties in the access bridge explorer, and it looks like the text on the node can be set to both name and description, and it's causing it to be read twice. In IntelliJ it's only set to the name:
Screenshot 2025-03-07 174848
Screenshot 2025-03-07 174935

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants