Non-linear font scaling #1867
Open
Non-linear font scaling #1867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ASalavei
reviewed
Mar 7, 2025
| import androidx.compose.ui.unit.fontscaling.FontScaleConverterTable | ||
|
|
||
| internal actual fun isNonLinearFontScalingActive(fontScale: Float): Boolean { | ||
| return fontScale >= UIKitContentSize.ExtraSmall.fontScale && fontScale !in 0.97f..1.03f |
There was a problem hiding this comment.
Could you please leave a comment in the code about these constants: 0.97f..1.03f ?
| */ | ||
| @Immutable | ||
| @JvmDefaultWithCompatibility | ||
| actual interface FontScaling { |
There was a problem hiding this comment.
That will change Desktop API. Please run ./gradlew desktopApiDump.
|
@igordmn , since there are changes in Desktop API, we need your approval. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapt Android non-linear font scaling and map Dynamic Type HIG to font scaling tables on IOS
Fixes https://youtrack.jetbrains.com/issue/CMP-738/Support-non-linear-text-scale-for-other-platforms
Testing
FontScalingTest.uikit.ktThis should be tested by QA
Release Notes
Features - iOS
Densitynow performs non-linear font scaling and conforms to HIG