Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: migrate InsertMethodsTest to JUnit 5 #4535

Merged

Conversation

MartinWitt
Copy link
Collaborator

#3919

Change Log

The following bad smells are refactored:

Junit4-@before

The JUnit 4 @Before annotation should be replaced with JUnit 5 @BeforeEach annotation.

JUnit4-@test

The JUnit 4 @Test annotation should be replaced with JUnit 5 @Test annotation.

JUnit4Assertion

The JUnit4 assertion should be replaced with JUnit5 Assertions.

The following has changed in the code:

JUnit4-@test

  • Replaced junit 4 test annotation with junit 5 test annotation in testInsertBefore
  • Replaced junit 4 test annotation with junit 5 test annotation in testInsertAfter
  • Replaced junit 4 test annotation with junit 5 test annotation in testInsertBeforeWithoutBrace
  • Replaced junit 4 test annotation with junit 5 test annotation in testInsertBeforeWithBrace
  • Replaced junit 4 test annotation with junit 5 test annotation in testInsertAfterWithoutBrace
  • Replaced junit 4 test annotation with junit 5 test annotation in testInsertAfterWithBrace
  • Replaced junit 4 test annotation with junit 5 test annotation in testInsertBeforeSwitchCase
  • Replaced junit 4 test annotation with junit 5 test annotation in testInsertAfterSwitchCase
  • Replaced junit 4 test annotation with junit 5 test annotation in insertBeforeAndUpdateParent

Junit4-@before

  • Replaced @Before annotation with @BeforeEach at method setup

JUnit4Assertion

  • Transformed junit4 assert to junit 5 assertion in testInsertBefore
  • Transformed junit4 assert to junit 5 assertion in testInsertAfter
  • Transformed junit4 assert to junit 5 assertion in testInsertBeforeWithoutBrace
  • Transformed junit4 assert to junit 5 assertion in testInsertBeforeWithBrace
  • Transformed junit4 assert to junit 5 assertion in testInsertAfterWithoutBrace
  • Transformed junit4 assert to junit 5 assertion in testInsertAfterWithBrace
  • Transformed junit4 assert to junit 5 assertion in testInsertBeforeSwitchCase
  • Transformed junit4 assert to junit 5 assertion in testInsertAfterSwitchCase
  • Transformed junit4 assert to junit 5 assertion in insertBeforeAndUpdateParent

 The following has changed in the code:
Replaced @before annotation with @beforeeach at method setup
Replaced junit 4 test annotation with junit 5 test annotation in testInsertBefore
Replaced junit 4 test annotation with junit 5 test annotation in testInsertAfter
Replaced junit 4 test annotation with junit 5 test annotation in testInsertBeforeWithoutBrace
Replaced junit 4 test annotation with junit 5 test annotation in testInsertBeforeWithBrace
Replaced junit 4 test annotation with junit 5 test annotation in testInsertAfterWithoutBrace
Replaced junit 4 test annotation with junit 5 test annotation in testInsertAfterWithBrace
Replaced junit 4 test annotation with junit 5 test annotation in testInsertBeforeSwitchCase
Replaced junit 4 test annotation with junit 5 test annotation in testInsertAfterSwitchCase
Replaced junit 4 test annotation with junit 5 test annotation in insertBeforeAndUpdateParent
Transformed junit4 assert to junit 5 assertion in testInsertBefore
Transformed junit4 assert to junit 5 assertion in testInsertAfter
Transformed junit4 assert to junit 5 assertion in testInsertBeforeWithoutBrace
Transformed junit4 assert to junit 5 assertion in testInsertBeforeWithBrace
Transformed junit4 assert to junit 5 assertion in testInsertAfterWithoutBrace
Transformed junit4 assert to junit 5 assertion in testInsertAfterWithBrace
Transformed junit4 assert to junit 5 assertion in testInsertBeforeSwitchCase
Transformed junit4 assert to junit 5 assertion in testInsertAfterSwitchCase
Transformed junit4 assert to junit 5 assertion in insertBeforeAndUpdateParent
@monperrus monperrus merged commit 2f62aec into INRIA:master Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants