Overriding/OverriddenMethodFilter #452
Conversation
| public class OverridingMethodFilter implements Filter<CtMethod<?>> { | ||
| private final CtExecutableReference<?> executableReference; | ||
|
|
||
| public OverridingMethodFilter(CtExecutableReference<?> executableReference) { |
There was a problem hiding this comment.
Take as parameter a CtMethod (and not a reference)?
avoid the getReference in usage (cf test) with encapsulatio
There was a problem hiding this comment.
I adopted the same logic of InvocationFilter for this: https://github.com/INRIA/spoon/blob/master/src/main/java/spoon/reflect/visitor/filter/InvocationFilter.java
There was a problem hiding this comment.
good idea to have a regular design. but I would rather update
CtInvocationFilter with a new constructor with a CtMethod.
There was a problem hiding this comment.
We don't need a CtMethod in InvocationFilter. Why we should have a constructor useless?
We need it for regaularity in the API. And this will be useful for users in the future. |
|
@monperrus PR ok. |
Closes #274