fix: fix pretty-printing ordering for record parameters #4366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
changed the test code to make it compatible with windows |
monperrus
changed the title
|
Thanks a lot @xzel23 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of creating a new test case, I added the missing checks to the existing one. The most important one is the one with the
head(records).toString(): changing the Set to LinkedHashSet makes all the other checks pass, but the output is still in reverse order.The fix in CloneHelper is less than ideal, but I cannot think of a better solution. IMHO the visitor pattern is overused in spoon, i. e. I cannot see a valid reason to use it for cloning. The visitor pattern is necessary for double dispatch, but if I didn't miss anything, cloning just needs a single dispatch.
Please review and comment.