Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

review: fix: Ignore Qodana action exit code #4301

Merged
merged 5 commits into from
Nov 23, 2021

Conversation

I-Al-Istannen
Copy link
Collaborator

@I-Al-Istannen I-Al-Istannen commented Nov 20, 2021

This PR just ignores failures in the qodana action (as its exit codes were a bit weird) and instead relies on the jq buildbreaker.

@I-Al-Istannen I-Al-Istannen changed the title wip: fix: Ignore Qodana action exit code review: fix: Ignore Qodana action exit code Nov 20, 2021
Copy link
Collaborator

@slarse slarse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will merge.

@algomaster99
Copy link
Contributor

@monperrus This PR has changes that need to be excluded from #4298. Please merge it.

@MartinWitt MartinWitt merged commit 5894aa5 into INRIA:master Nov 23, 2021
@MartinWitt
Copy link
Collaborator

@I-Al-Istannen thanks for the fix.

@slarse
Copy link
Collaborator

slarse commented Nov 23, 2021

I of course meant LGTM, will forget to merge.

@monperrus
Copy link
Collaborator

Thanks for the great group work.

@I-Al-Istannen I-Al-Istannen deleted the fix/qodana branch November 24, 2021 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants