Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use range for dependency maven-model #4252

Merged
merged 1 commit into from
Oct 27, 2021
Merged

use range for dependency maven-model #4252

merged 1 commit into from
Oct 27, 2021

Conversation

monperrus
Copy link
Collaborator

closes #4248

@monperrus monperrus mentioned this pull request Oct 22, 2021
Closed
@monperrus
Copy link
Collaborator Author

WDYT @vmassol

@vmassol
Copy link

vmassol commented Oct 27, 2021

WDYT @vmassol

I guess it should work. You should use the lowest value that will work but for XWiki 3.6.0 is fine ;)

@monperrus
Copy link
Collaborator Author

then ready for merge @slarse

slarse
slarse approved these changes Oct 27, 2021
View reviewed changes
Copy link
Collaborator

@slarse slarse left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This solves the immediate issue with XWiki, so I'll merge and we can keep discussing whether or not it's wise to use the lowest possible version at the lower end of the range if anyone feels like it :)

@slarse slarse merged commit 70211b8 into master Oct 27, 2021
@slarse slarse deleted the monperrus-patch-2 branch October 27, 2021 19:58
@monperrus monperrus mentioned this pull request Mar 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slarse slarse slarse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Seems Spoon requires maven-model 3.8.2 when 3.6.0 seems enough
3 participants
@monperrus @vmassol @slarse