Fix SuperInheritanceHierarchyFunction in noClassPath mode #1281
Conversation
Revapi Analysis resultsOld API: fr.inria.gforge.spoon:spoon-core:jar:5.7.0-20170503.161928-72 New API: fr.inria.gforge.spoon:spoon-core:jar:5.7.0-SNAPSHOT Detected changes: 0. |
| * Use it instead of {@link CtScannerListener} | ||
| * if you need to know whether visited type reference is class or interface | ||
| */ | ||
| public static class Listener implements CtScannerListener { |
There was a problem hiding this comment.
can we make this class private or package protected?
There was a problem hiding this comment.
It is better CtScannerListener. so it might be interesting for some spoon clients.
It is true that they might extend DistinctTypeListener too, but it provides some extra behavior, which might be NOT needed by some clients.
But technically I can make it private, so we keep Spoon API as small as possible.
So should I really make it private?
|
But technically I can make it private, so we keep Spoon API as small as possible.
So should I really make it private
Yes, let's keep the API surface small.
If somebody finds it and needs it, we'd be happy to make it visible.
|
Revapi Analysis resultsOld API: fr.inria.gforge.spoon:spoon-core:jar:5.7.0-20170504.074858-74 New API: fr.inria.gforge.spoon:spoon-core:jar:5.7.0-SNAPSHOT Detected changes: 0. |
|
It is private now |
This PR improves algorithm of SuperInheritanceHierarchyFunction by way it works better in no class path mode.
This fix is needed to pass tests of #1220