Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing unnecessary steps and passing extra arguments for tiled inference #469

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Removing unnecessary steps and passing extra arguments for tiled inference #469

wants to merge 1 commit into from
+7 −8

Conversation

Joao-L-S-Almeida
Copy link
Member

@Joao-L-S-Almeida Joao-L-S-Almeida commented Mar 3, 2025 •
edited
Loading

No description provided.

@Joao-L-S-Almeida Joao-L-S-Almeida changed the title Removing unnecessary steps and passing extra arguments for tiled infe… Removing unnecessary steps and passing extra arguments for tiled inference Mar 3, 2025
@Joao-L-S-Almeida Joao-L-S-Almeida self-assigned this Mar 3, 2025
@Joao-L-S-Almeida Joao-L-S-Almeida added 0.99.9 bug Something isn't working labels Mar 3, 2025
@paolofraccaro
Copy link
Collaborator

Changes look good. Did we add any test for this?

@Joao-L-S-Almeida
Copy link
Member Author

We just have examples inside tests/resources/configs, but no automatic test. I'll add them.

@Joao-L-S-Almeida
Copy link
Member Author

It seems no of our currently tested models really uses this dicttionary rest for extra arguments. Maybe SatMAE or Clay are using it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paolofraccaro paolofraccaro Awaiting requested review from paolofraccaro

At least 1 approving review is required to merge this pull request.

Assignees

@Joao-L-S-Almeida Joao-L-S-Almeida

Labels
0.99.9 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Joao-L-S-Almeida @paolofraccaro