Initial work on File and Array<File> support #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also see issue HriBB#3
|
Hmmm ... can we detect variable type from mutation? For example ... or But we still need to check for |
LinusU
reviewed
Jan 16, 2017
| @@ -46,6 +67,10 @@ export class UploadNetworkInterface extends HTTPFetchNetworkInterface { | |||
| let v = request.variables[key] | |||
| if (v instanceof FileList) { | |||
| Array.from(v).forEach(f => body.append(key, f)) | |||
| } else if (isArrayOfFiles(v)) { | |||
| for (var file in v) { | |||
| return body.append(key, file); // this part seems buggy | |||
There was a problem hiding this comment.
return here will cause only the first file to get appended
LinusU
reviewed
Jan 16, 2017
|
|
||
| isUpload({ request }) { | ||
| if (request.variables) { | ||
| for (let key in request.variables) { | ||
| if (request.variables[key] instanceof FileList) { | ||
| return true | ||
| } | ||
| if (request.variables[key] instanceof File) { | ||
| return true; | ||
| } |
LinusU
reviewed
Jan 16, 2017
| return true; | ||
| } | ||
| if (this.isArrayOfFiles(request.variables[key])) { | ||
| return true; |
There was a problem hiding this comment.
The rest of this file doesn't use semicolons, probably following Standard Style
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also see issue #3. My initial work on this. Got the checking to work, but adding the array to the request body fails. I've not tested appending only a File to the body.