Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update references to shielded transactions #632

Merged
merged 5 commits into from
Jan 29, 2024

Conversation

ptagl
Copy link
Contributor

@ptagl ptagl commented Jan 24, 2024

After the development of the removal of shielded transactions #628, docs on the repository have been updated to reflect the current status of Zend and remove references to any feature that is not available anymore.

Some sections have been kept and marked as "deprecated" since they may still be useful somehow after the hard fork activation.

Some of them have been removed as not applicable anymore after the next upcoming hardfork.
Copy link
Member

@cronicc cronicc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, comments non-blocking

Copy link
Contributor

@JackPiri JackPiri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR is fine to me.
Just mentioning in payment-api.md there are multiple references to privacy features (z_* RPCs, zaddr, zcash-cli, etc) probably we want to get rid of.
Thanks

Copy link
Contributor

@a-petrini a-petrini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for me, I left a minor non/blocking comment

@ptagl
Copy link
Contributor Author

ptagl commented Jan 25, 2024

I've added a couple of commits to address the requested changes, let me know if they look ok.

payment-api.md could be extended to add more information (for instance how the z_mergetoaddress command works), but if it's not crucial, we may postpone this task to another PR.

@ptagl ptagl merged commit ebafd31 into main Jan 29, 2024
1 check failed
@ptagl ptagl deleted the pt/update_docs_after_shielded_removal branch January 29, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants