-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update references to shielded transactions #632
Conversation
Some of them have been removed as not applicable anymore after the next upcoming hardfork.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, comments non-blocking
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR is fine to me.
Just mentioning in payment-api.md
there are multiple references to privacy features (z_* RPCs, zaddr, zcash-cli, etc) probably we want to get rid of.
Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good for me, I left a minor non/blocking comment
I've added a couple of commits to address the requested changes, let me know if they look ok.
|
After the development of the removal of shielded transactions #628, docs on the repository have been updated to reflect the current status of Zend and remove references to any feature that is not available anymore.
Some sections have been kept and marked as "deprecated" since they may still be useful somehow after the hard fork activation.