Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grammatical and Punctuation Corrections and small other improvements for brand accuracy #625

Merged
merged 3 commits into from
Dec 13, 2023

Conversation

mantle0x
Copy link
Contributor

@mantle0x mantle0x commented Dec 9, 2023

In the "Install for Windows" section, the phrase "(chose: /usr/bin/x86_64-w64-mingw32-g++-posix)" might be clearer as an instruction. For example, "Choose the option: /usr/bin/x86_64-w64-mingw32-g++-posix."

Grammatical and Punctuation Corrections:

In the phrase "building on Windows is not supported yet" (under the "Install for Windows" section), consider changing it to "Building on Windows is not currently supported" for clarity.
In the "Running Regression Tests" section, "MacOS" should be written as "macOS" to align with Apple's branding.

In the "Running Regression Tests" section, "MacOS" should be written as "macOS" to align with Apple's branding.
In the phrase "building on Windows is not supported yet" (under the "Install for Windows" section), consider changing it to "Building on Windows is not currently supported" for clarity.
In the "Install for Windows" section, the phrase "(chose: /usr/bin/x86_64-w64-mingw32-g++-posix)" might be clearer as an instruction. For example, "Choose the option: /usr/bin/x86_64-w64-mingw32-g++-posix."
Copy link
Contributor

@drgora drgora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR, looks ok to me.

Copy link
Contributor

@ptagl ptagl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mantle0x for the PR, it's always good to have people contributing to Zend, looking forward to seeing more improvements from you!

@ptagl ptagl merged commit a55e24a into HorizenOfficial:main Dec 13, 2023
@mantle0x
Copy link
Contributor Author

mantle0x commented Dec 13, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants