Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OS -independent mc-crypto log configuration file #621

Merged
merged 4 commits into from
Nov 15, 2023

Conversation

a-petrini
Copy link
Contributor

This PR simplify the management of the configuration file for the newly introduced mc-crypto logger, adapting the configuration depending by the underlying OS zend is running on

@a-petrini a-petrini requested review from drgora, ptagl and JackPiri and removed request for drgora November 14, 2023 11:01
Copy link
Contributor

@JackPiri JackPiri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left few minor comments, probably only the one related to networks directories really worth being addressed. Apart from that the PR is fine to me.
Thanks

@a-petrini a-petrini force-pushed the ap/mc_logger_conf_update branch from 840788f to 7e8f0a5 Compare November 15, 2023 10:25
@a-petrini a-petrini force-pushed the ap/mc_logger_conf_update branch from 7e8f0a5 to 9be4255 Compare November 15, 2023 13:58
@ptagl ptagl merged commit 71aa33d into main Nov 15, 2023
@ptagl ptagl deleted the ap/mc_logger_conf_update branch November 15, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants