Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix startup warning #619

Merged
merged 3 commits into from
Nov 8, 2023
Merged

Fix startup warning #619

merged 3 commits into from
Nov 8, 2023

Conversation

drgora
Copy link
Contributor

@drgora drgora commented Nov 8, 2023

This PR fixes the startup warning message that is shown when default configuration files are missing. The message now shows the actual path that is being used, and not the default hardcoded one.

Also, if copying default config files fail, the execution fails with a proper error message, instead of creating empty config file in the destination directory.

Replace hardcoded default paths with the actual ones that are used in the current execution.
Copy link
Contributor

@JackPiri JackPiri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried running this version, I confirm both issues have been solved.
Thanks

Copy link
Contributor

@a-petrini a-petrini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for this fix

@ptagl ptagl merged commit 4bae361 into main Nov 8, 2023
@ptagl ptagl deleted the dr/fix_startup_warning branch November 8, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants