Fixed a sporadic error in sc_cert_nonceasing.py #618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackPiri
approved these changes
Oct 30, 2023
It was related to a wrong "minconf" parameter that was sometimes causing a transaction to be created with an input that could eventually "disappear" to the disconnection of some blocks. Made few minor improvements to checkblockatheight.py and mempool_size_limit_even_more.py as well.
ptagl
force-pushed
the
pt/fix_sc_cert_nonceasing.py
branch
from
653e395 to
399382d
Compare
JackPiri
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error was related to a wrong
minconfparameter that was sometimes causing a transaction to be created with an input that could eventually "disappear" due to the disconnection of some blocks.