[ZEND-569] Remove boost threads from networking system #612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-petrini
changed the title
drgora
approved these changes
Sep 29, 2023
JackPiri
suggested changes
Sep 29, 2023
ptagl
suggested changes
Oct 1, 2023
a-petrini
force-pushed
the
ap/remove_boost_threads_from_net_ZEND-569
branch
2 times, most recently
from
587482a to
da73f97
Compare
titusen
approved these changes
Oct 2, 2023
There was a problem hiding this comment.
The "CThreadInterrupt" class could also throw an exception just like boost::interrupt does. It works better when interrupt is nested in function calls. Still if a thread was interrupted it can be achieved by if (interrupted) throw error but requires more syntax. So for our needs it's enough.
LGTM, thanks.
…vert to std::thread (This compiles but shouldn't work yet)
(This compiles but shouldn't work yet)
(This compiles but shouldn't work yet)
(This compiles but shouldn't work yet)
a-petrini
force-pushed
the
ap/remove_boost_threads_from_net_ZEND-569
branch
from
da73f97 to
e2591b7
Compare
ptagl
approved these changes
Oct 3, 2023
JackPiri
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes all the instances of
boost::threadfrom the networking subsystem, in favor of STL<thread>library.One key difference between the libraries is that
boost::threads are interruptible; this feature has been replicated by the newly introduced classCThreadInterrupt.The PR also removes the
boost::condition_variableas well, preferring the STL equivalent.Finally,
boost::thread_grouphas been removed as well, but it has not been replaced with anything equivalent.