Ap/accept tx to mempool call consistency #602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackPiri
approved these changes
Sep 6, 2023
ptagl
approved these changes
Sep 6, 2023
This change updates AcceptTxToMemoryPool() enforcing the usage of the "CTxMemPool pool" input parameter instead of relying on the global mempool instance. This change also inolve the function GetMinRelayFee() that is updated in the same way.
This change updates several gtest that failed when executed singularly with the --gtest_filter option, and not when executed inside the complete gtest suite. The change added a few explicit initialization of the mempool and connection manager global instances, to prevent segfault errors
ptagl
force-pushed
the
ap/acceptTxToMempool_call_consistency
branch
from
502e8a3 to
d6469f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.