Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring for sc_cert_getblocktemplate.py #581

Merged
merged 2 commits into from
Aug 11, 2023
Merged

Refactoring for sc_cert_getblocktemplate.py #581

merged 2 commits into from
Aug 11, 2023

Conversation

JackPiri
Copy link
Contributor

@JackPiri JackPiri commented Jul 26, 2023 •
edited by ptagl
Loading

  • Python script performs optional check based on overall execution time
  • Pyhton script optimization

@JackPiri JackPiri force-pushed the gp/sc_cert_getblocktemplate_refactoring branch from 687d858 to a4a89ee Compare July 27, 2023 13:20
titusen
titusen approved these changes Jul 31, 2023
View reviewed changes
Copy link
Contributor

@titusen titusen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

a-petrini
a-petrini approved these changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

@a-petrini a-petrini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a non-blocking comment, but I would like to hear your opinion about!
No other remarks for the rest. Thanks for this PR.

@JackPiri JackPiri force-pushed the gp/sc_cert_getblocktemplate_refactoring branch 2 times, most recently from a79cfb0 to 05a1daa Compare August 8, 2023 12:31
titusen
titusen approved these changes Aug 8, 2023
View reviewed changes
Copy link
Contributor

@titusen titusen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@JackPiri JackPiri force-pushed the gp/sc_cert_getblocktemplate_refactoring branch from 2ae1a3e to ef9dc35 Compare August 10, 2023 07:23
drgora
drgora approved these changes Aug 10, 2023
View reviewed changes
Copy link
Contributor

@drgora drgora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks! I Only left one totally negligible comment, feel free to ignore it.

@JackPiri JackPiri force-pushed the gp/sc_cert_getblocktemplate_refactoring branch from ef9dc35 to 1b52cc3 Compare August 10, 2023 14:24
Paolo Tagliaferri and others added 2 commits August 11, 2023 10:14
@ptagl ptagl force-pushed the gp/sc_cert_getblocktemplate_refactoring branch from 1b52cc3 to a6c21c6 Compare August 11, 2023 09:17
@ptagl ptagl merged commit e7ca55a into main Aug 11, 2023
@ptagl ptagl deleted the gp/sc_cert_getblocktemplate_refactoring branch August 11, 2023 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-petrini a-petrini a-petrini approved these changes

@ptagl ptagl ptagl approved these changes

@titusen titusen titusen approved these changes

@drgora drgora drgora approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JackPiri @ptagl @titusen @drgora @a-petrini