Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mavsdk: build on Mojave #77504

Closed
wants to merge 1 commit into from
Closed

Conversation

carlocab
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

Not sure if this will work, as I'm not running Mojave. But a similar fix seems to have worked elsewhere.

@carlocab carlocab mentioned this pull request May 18, 2021
5 tasks
@carlocab carlocab force-pushed the mavsdk-mojave branch 2 times, most recently from 50239f4 to 3443bf7 Compare May 18, 2021 22:58
Also, clean up argument alignment in test.
carlocab added a commit to carlocab/homebrew-core that referenced this pull request May 18, 2021
depends_on "[email protected]"
depends_on "protobuf"
depends_on "re2"
depends_on "tinyxml2"

uses_from_macos "zlib"

# To update the resources, use homebrew-pypi-poet on the PyPI package `protoc-gen-mav-sdk`.
on_macos do
depends_on "llvm" if MacOS.version <= :mojave
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't work as a build-only dependency, sadly.

@BrewTestBot
Copy link
Member

:shipit: @carlocab has triggered a merge.

BrewTestBot pushed a commit that referenced this pull request May 19, 2021
Same comment as in #77504.

Closes #77505.

Signed-off-by: BrewTestBot <[email protected]>
@carlocab carlocab deleted the mavsdk-mojave branch May 19, 2021 20:18
@github-actions github-actions bot added the outdated PR was locked due to age label Jun 19, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants