Feat/poc connection pool slots #1230
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bencher Report| Branch | feat/poc-connectionPoolSlots |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result minutes (m) (Result Δ%) | Lower Boundary minutes (m) (Limit %) | Upper Boundary minutes (m) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold | 1.70 m(+4.09%)Baseline: 1.63 m | 1.47 m (86.46%) | 1.80 m (94.63%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Slotting the connections of the p2p network into types ( incoming, outgoing, discovered and check_peers) and set a limit for each, in order to avoid cross-flooding of features by malicious attackers, which may jam all types of connections by flooding one type.
Acceptance Criteria
The full node must accept at most N incoming connections.
The full node must open at most M outgoing connections to verified entry points.
The full node must keep at most P connections to discovered peers.
The full node must have slots available to check for untrusted entry points.
The full node must cycle through outgoing and incoming connections. (this one was demoted in a meeting, to be its own pr/rfc).
Checklist