Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(reactor): add IReactorProcess and IReactorSocket support [part 3/11] #1163

Open
wants to merge 1 commit into
base: refactor/p2p/peer-connections
Choose a base branch
from

Conversation

glevco
Copy link
Contributor

@glevco glevco commented Oct 22, 2024

Depends on #1174

Motivation

For the P2P Multiprocess project, we'll need our Twisted reactor to define support for IReactorProcess and IReactorSocket. This PR does this, and also reorganizes our existing simulator and test reactor classes, unifying them for simplicity.

Acceptance Criteria

  • Add Twisted's IReactorProcess and IReactorSocket to our ReactorProtocol.
  • Unify our simulator and test MemoryReactor and MemoryReactorClock definitions, adding support for IReactorProcess.
  • No changes in behavior.

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@glevco glevco self-assigned this Oct 22, 2024
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 90.24390% with 4 lines in your changes missing coverage. Please review.

Project coverage is 84.84%. Comparing base (eee9bb0) to head (72330e8).

Files with missing lines Patch % Lines
hathor/reactor/reactor_socket_protocol.py 76.92% 3 Missing ⚠️
hathor/reactor/reactor_process_protocol.py 87.50% 1 Missing ⚠️
Additional details and impacted files
@@                        Coverage Diff                        @@
##           refactor/p2p/peer-connections    #1163      +/-   ##
=================================================================
+ Coverage                          84.81%   84.84%   +0.02%     
=================================================================
  Files                                315      318       +3     
  Lines                              24392    24427      +35     
  Branches                            3700     3702       +2     
=================================================================
+ Hits                               20689    20726      +37     
+ Misses                              2997     2993       -4     
- Partials                             706      708       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glevco glevco changed the title feat(reactor): add IReactorProcess and IReactorSocket support feat(reactor): add IReactorProcess and IReactorSocket support [part 4/8] Oct 22, 2024
@glevco glevco marked this pull request as ready for review October 22, 2024 16:00
@glevco glevco force-pushed the feat/reactor-process-socket branch from 8ab18f4 to 90e2208 Compare October 23, 2024 00:25
@glevco glevco changed the title feat(reactor): add IReactorProcess and IReactorSocket support [part 4/8] feat(reactor): add IReactorProcess and IReactorSocket support [part 2/8] Oct 23, 2024
@glevco glevco force-pushed the refactor/vertex-handler/remove-p2p-manager branch from 14e43d1 to 3203fbc Compare October 24, 2024 20:41
Base automatically changed from refactor/vertex-handler/remove-p2p-manager to master October 25, 2024 13:18
@glevco glevco force-pushed the feat/reactor-process-socket branch from 90e2208 to f746865 Compare October 27, 2024 21:24
Copy link

github-actions bot commented Oct 27, 2024

🐰 Bencher Report

Branchfeat/reactor-process-socket
Testbedubuntu-22.04
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
nanoseconds (ns)
(Result Δ%)
Lower Boundary
nanoseconds (ns)
(Limit %)
Upper Boundary
nanoseconds (ns)
(Limit %)
sync-v2 (up to 20000 blocks)📈 view plot
🚷 view threshold
101,458,552,133.78
(-0.34%)
91,620,330,173.56
(90.30%)
111,980,403,545.46
(90.60%)
🐰 View full continuous benchmarking report in Bencher

@glevco glevco force-pushed the feat/reactor-process-socket branch from f746865 to 48e4120 Compare November 5, 2024 18:08
@glevco glevco changed the title feat(reactor): add IReactorProcess and IReactorSocket support [part 2/8] feat(reactor): add IReactorProcess and IReactorSocket support [part 3/10] Nov 6, 2024
@glevco glevco changed the base branch from master to refactor/p2p/peer-connections November 6, 2024 15:16
@glevco glevco force-pushed the feat/reactor-process-socket branch from 48e4120 to 25373c2 Compare November 6, 2024 15:19
@glevco glevco force-pushed the refactor/p2p/peer-connections branch from 09ef898 to 497dac3 Compare November 7, 2024 00:58
@glevco glevco force-pushed the feat/reactor-process-socket branch from 25373c2 to 2c9346f Compare November 7, 2024 01:57
@glevco glevco changed the title feat(reactor): add IReactorProcess and IReactorSocket support [part 3/10] feat(reactor): add IReactorProcess and IReactorSocket support [part 3/11] Nov 7, 2024
@glevco glevco force-pushed the refactor/p2p/peer-connections branch from 497dac3 to eee9bb0 Compare November 8, 2024 15:44
@glevco glevco force-pushed the feat/reactor-process-socket branch from 2c9346f to 72330e8 Compare November 8, 2024 15:44
@glevco glevco force-pushed the refactor/p2p/peer-connections branch 2 times, most recently from 8fbf968 to 8ed5b0d Compare November 25, 2024 16:09
@glevco glevco force-pushed the feat/reactor-process-socket branch from 72330e8 to a77aba6 Compare November 25, 2024 16:12
@jansegre jansegre mentioned this pull request Dec 6, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

3 participants