-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(reactor): add IReactorProcess and IReactorSocket support [part 3/11] #1163
Open
glevco
wants to merge
1
commit into
refactor/p2p/peer-connections
Choose a base branch
from
feat/reactor-process-socket
base: refactor/p2p/peer-connections
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## refactor/p2p/peer-connections #1163 +/- ##
=================================================================
+ Coverage 84.81% 84.84% +0.02%
=================================================================
Files 315 318 +3
Lines 24392 24427 +35
Branches 3700 3702 +2
=================================================================
+ Hits 20689 20726 +37
+ Misses 2997 2993 -4
- Partials 706 708 +2 ☔ View full report in Codecov by Sentry. |
1 task
8ab18f4
to
90e2208
Compare
1 task
14e43d1
to
3203fbc
Compare
Base automatically changed from
refactor/vertex-handler/remove-p2p-manager
to
master
October 25, 2024 13:18
90e2208
to
f746865
Compare
|
Branch | feat/reactor-process-socket |
Testbed | ubuntu-22.04 |
Click to view all benchmark results
Benchmark | Latency | Benchmark Result nanoseconds (ns) (Result Δ%) | Lower Boundary nanoseconds (ns) (Limit %) | Upper Boundary nanoseconds (ns) (Limit %) |
---|---|---|---|---|
sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold | 101,458,552,133.78 (-0.34%) | 91,620,330,173.56 (90.30%) | 111,980,403,545.46 (90.60%) |
f746865
to
48e4120
Compare
48e4120
to
25373c2
Compare
09ef898
to
497dac3
Compare
25373c2
to
2c9346f
Compare
497dac3
to
eee9bb0
Compare
2c9346f
to
72330e8
Compare
8fbf968
to
8ed5b0d
Compare
72330e8
to
a77aba6
Compare
msbrogli
approved these changes
Dec 5, 2024
jansegre
approved these changes
Dec 6, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #1174
Motivation
For the P2P Multiprocess project, we'll need our Twisted reactor to define support for
IReactorProcess
andIReactorSocket
. This PR does this, and also reorganizes our existing simulator and test reactor classes, unifying them for simplicity.Acceptance Criteria
IReactorProcess
andIReactorSocket
to ourReactorProtocol
.MemoryReactor
andMemoryReactorClock
definitions, adding support forIReactorProcess
.Checklist
master
, confirm this code is production-ready and can be included in future releases as soon as it gets merged