Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix closing html tag #12

Merged
merged 1 commit into from
Aug 4, 2022
Merged

Fix closing html tag #12

merged 1 commit into from
Aug 4, 2022

Conversation

tomhatzer
Copy link
Contributor

This PR fixes #10

bruhmastir
bruhmastir reviewed Jul 24, 2021
View reviewed changes
Copy link

@bruhmastir bruhmastir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the issue is correctly addressed in the change to index.js, with most other changes being just version upgrades from 1.0.7 to 1.0.8. I couldn't review the change to .min.js.map file however because of github thinking the line code is too long.

@lexoyo
Copy link

lexoyo commented Apr 4, 2022

+1 for merging this (with rebuilding of dist/)

@artf artf merged commit cc1b557 into GrapesJS:master Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bruhmastir bruhmastir bruhmastir left review comments

@artf artf artf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Export to ZIP Closing HTML tag is not a closing tag
4 participants
@tomhatzer @lexoyo @artf @bruhmastir