core(cls-culprits-insight): implement #16357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamraine
approved these changes
Feb 25, 2025
| @@ -67,6 +67,8 @@ const UIStrings = { | |||
| columnFailingElem: 'Failing Elements', | |||
| /** Label for a column in a data table; entries will be a description of the table item. */ | |||
| columnDescription: 'Description', | |||
| /** Label for a row in a data table; the row represents the total number of something. */ | |||
| total: 'Total', | |||
| /** Label for a row in a data table; entries will be the total number and byte size of all resources loaded by a web page. */ | |||
| totalResourceType: 'Total', | |||
There was a problem hiding this comment.
Could we just remove totalResourceType now?
There was a problem hiding this comment.
I don't know for sure. maybe the contexts encourage different translations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #16323
Had to add a TextValue for rendering a text value (overriding the table header defn).