Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(dbw): revert unload handler expectations #16353

Merged
merged 1 commit into from
Feb 24, 2025
Merged

tests(dbw): revert unload handler expectations #16353

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 0 additions & 23 deletions cli/test/smokehouse/test-definitions/dobetterweb.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,13 +249,6 @@ const expectations = {
description: 'Failed to load resource: the server responded with a status of 404 (Not Found)',
sourceLocation: {url: 'http://localhost:10200/favicon.ico'},
},
{
// Unload handlers were moved behind a permission policy in M135.
_minChromiumVersion: '135',
source: 'violation',
description: 'Permissions policy violation: unload is not allowed in this document.',
sourceLocation: {url: 'http://localhost:10200/dobetterweb/dbw_tester.html'},
},
],
},
},
Expand Down Expand Up @@ -328,8 +321,6 @@ const expectations = {
subItems: undefined,
},
{
// Unload handlers were moved behind a permission policy in M135.
_maxChromiumVersion: '134',
value: 'UnloadHandler',
source: {
type: 'source-location',
Expand Down Expand Up @@ -434,8 +425,6 @@ const expectations = {
details: {
items: [
{
// Unload handlers were moved behind a permission policy in M135.
_maxChromiumVersion: '134',
reason: 'The page has an unload handler in the main frame.',
failureType: 'Actionable',
subItems: {
Expand All @@ -444,22 +433,10 @@ const expectations = {
}],
},
},
{
// Unload handlers were moved behind a permission policy in M135.
_minChromiumVersion: '135',
reason: 'There were permission requests upon navigating away.',
failureType: 'Pending browser support',
subItems: {
items: [{
frameUrl: 'http://localhost:10200/dobetterweb/dbw_tester.html',
}],
},
},
{
// This issue only appears in the DevTools runner for some reason.
// TODO: Investigate why this doesn't happen on the CLI runner.
_runner: 'devtools',
_maxChromiumVersion: '134',
reason: 'There were permission requests upon navigating away.',
failureType: 'Pending browser support',
subItems: {
Expand Down