report: remove href from category score gauge #13180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjclark
requested review from
patrickhulce
and removed request for
a team
connorjclark
commented
Oct 6, 2021
| @@ -333,7 +333,7 @@ export class CategoryRenderer { | |||
| renderScoreGauge(category, groupDefinitions) { // eslint-disable-line no-unused-vars | |||
| const tmpl = this.dom.createComponent('gauge'); | |||
| const wrapper = this.dom.find('a.lh-gauge__wrapper', tmpl); | |||
| this.dom.safelySetHref(wrapper, `#${category.id}`); | |||
There was a problem hiding this comment.
alternative: remove href from
lighthouse/report/assets/templates.html
Line 552 in 236b30d
patrickhulce
reviewed
Oct 6, 2021
patrickhulce
reviewed
Oct 6, 2021
There was a problem hiding this comment.
@paulirish seems like you have a plan for this, shall I designate you as the reviewer here?
| @@ -549,7 +549,7 @@ | |||
|
|
|||
| <!-- Lighthouse score gauge --> | |||
| <template id="gauge"> | |||
| <a href="#" class="lh-gauge__wrapper"> | |||
| <a class="lh-gauge__wrapper"> | |||
There was a problem hiding this comment.
should these even be anchors then?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #13170