Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc(build): remove template.html from devtools report resources #12891

Merged
merged 4 commits into from
Aug 13, 2021
Merged

misc(build): remove template.html from devtools report resources #12891

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a2797f0
misc(build): remove template.html from devtools report resources
connorjclark Aug 10, 2021
192bbff
rm setTemplateContext
connorjclark Aug 11, 2021
9ddc742
Merge remote-tracking branch 'origin/master' into dt-templates
connorjclark Aug 11, 2021
63531fa
Merge remote-tracking branch 'origin/master' into dt-templates
connorjclark Aug 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion build/build-dt-report-resources.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ fs.mkdirSync(distDir, {recursive: true});
writeFile('report.js', htmlReportAssets.REPORT_JAVASCRIPT);
writeFile('report.css', htmlReportAssets.REPORT_CSS);
writeFile('standalone-template.html', htmlReportAssets.REPORT_TEMPLATE);
writeFile('templates.html', '<div>Empty file. Remove on next roll to CDT</div>');
writeFile('report.d.ts', 'export {}');
writeFile('report-generator.d.ts', 'export {}');

Expand Down
7 changes: 0 additions & 7 deletions report/renderer/report-renderer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,13 +54,6 @@ export class ReportRenderer {
return container;
}

/**
* @param {ParentNode} _
*/
setTemplateContext(_) {
// Removed, exists until usage is removed from CDT.
}

/**
* @param {LH.ReportResult} report
* @return {DocumentFragment}
Expand Down
7 changes: 0 additions & 7 deletions report/renderer/report-ui-features.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,13 +171,6 @@ export class ReportUIFeatures {
}
}

/**
* @param {ParentNode} _
*/
setTemplateContext(_) {
// Removed, exists until usage is removed from CDT.
}

/**
* @param {{container?: Element, text: string, icon?: string, onClick: () => void}} opts
*/
Expand Down