Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Implementation of MCServer$MCCommand.compareTo(Object) #17

Merged
merged 2 commits into from
Feb 14, 2024
Merged

Fix Implementation of MCServer$MCCommand.compareTo(Object) #17

merged 2 commits into from
Feb 14, 2024

Conversation

glowredman
Copy link
Member

This replicates the behaviour of CommandBase, using the Comparable implementation to sort the commands by name when auto-completing or using /help.
This was discovered using HelpFixer:

[14:03:36] [Server thread/WARN] [FML/HelpFixer]: [HelpFixer] Command minetweaker incorrectly overrides compareTo: minetweaker.mc1710.server.MCServer$MCCommand

@glowredman glowredman requested a review from a team February 14, 2024 19:30
@glowredman glowredman merged commit 0a70a6f into master Feb 14, 2024
1 check passed
@glowredman glowredman deleted the glowredman-patch-1 branch February 14, 2024 19:48
@glowredman glowredman mentioned this pull request Feb 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eigenraven eigenraven eigenraven approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@glowredman @eigenraven