forked from plone/plone.app.iterate
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update plone.app.iterate with master of original. #2
Open
adrianschulz
wants to merge
255
commits into
FHNW:master
Choose a base branch
from
plone:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ci skip]
[ci skip]
Use `get_installer` in general upgrade step.
[ci-skip]
[ci-skip]
fix relative imports for py3
Run main tests against plone.app.contenttypes; skip AT tests if no AT
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
Avoid test setup error for AT layer when it's not installed
updates: - [github.com/asottile/pyupgrade: v3.17.0 → v3.19.0](asottile/pyupgrade@v3.17.0...v3.19.0) - [github.com/mgedmin/check-manifest: 0.49 → 0.50](mgedmin/check-manifest@0.49...0.50) - [github.com/mgedmin/check-python-versions: 0.22.0 → 0.22.1](mgedmin/check-python-versions@0.22.0...0.22.1)
[pre-commit.ci] pre-commit autoupdate [ci-skip]
updates: - [github.com/asottile/pyupgrade: v3.19.0 → v3.19.1](asottile/pyupgrade@v3.19.0...v3.19.1)
[pre-commit.ci] pre-commit autoupdate [ci-skip]
Fix DeprecationWarnings.
Allows working copy of Plone Site
This fixes the tests that fail now that the plone.locking behavior is required for check-out/in, which already was required in practice anyway.
It was not needed, and in Plone 6.1 it causes a warning because `plone.app.discussion` is not available: ``` DeprecationWarning: No behavior registration found for behavior named "plone.allowdiscussion" for factory "FolderishDocument" - trying deprecated fallback lookup (will be removed in 3.0)..." ```
It was no longer used. We still have the plone.app.iterate:testingdx profile.
This prevents z3c.dependencychecker from complaining that plone.app.contenttypes is missing as dependency. Also, until now this testingdx profile (and the test profile that I removed in the previous commit) was always available, so not only during testing, and that is not what we want.
cancel_allowed tests
cancel_allowed tests of test_containers.py
…t_iterate.py to test_containers.py. test_iterate.py is meant for testing non-folderish items. test_containers.py is meant for testing folderish containers.
This only influences test_baselineVersionCreated, making sure that documents initially have no versions in the repository.
Do this with items and containers, versionable and not versionable, lockable and not lockable.
Only create a LockableFolder in one test, to test the combination of a portal_type that cannot be versioned, but can be locked.
Do not allow checkout when item is not lockable or is already locked.
[ci skip]
[ci skip]
[ci skip]
updates: - [github.com/pycqa/isort: 5.13.2 → 6.0.0](PyCQA/isort@5.13.2...6.0.0) - [github.com/psf/black: 24.10.0 → 25.1.0](psf/black@24.10.0...25.1.0) - [github.com/codespell-project/codespell: v2.3.0 → v2.4.1](codespell-project/codespell@v2.3.0...v2.4.1)
for more information, see https://pre-commit.ci
[pre-commit.ci] pre-commit autoupdate [ci-skip]
updates: - [github.com/pycqa/isort: 6.0.0 → 6.0.1](PyCQA/isort@6.0.0...6.0.1) - [github.com/PyCQA/flake8: 7.1.1 → 7.1.2](PyCQA/flake8@7.1.1...7.1.2)
[pre-commit.ci] pre-commit autoupdate [ci-skip]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.