#1719 [List] add: last dates and answer/question on control and survey #1750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evarisk-micka
force-pushed
the
add_infos_on_list
branch
from
0c621b3 to
fd56108
Compare
theodaviddd
requested changes
Aug 27, 2024
| $lastValidateAction = $actioncomm->getActions(0, $object->id, 'control@digiquali', ' AND a.code = "AC_CONTROL_VALIDATE"', 'a.datep', 'DESC', 1); | ||
| $lastReOpenAction = $actioncomm->getActions(0, $object->id, 'control@digiquali', ' AND a.code = "AC_CONTROL_UNVALIDATE"', 'a.datep', 'DESC', 1); | ||
|
|
||
| $lastValidateDate = (is_array($lastValidateAction) && !empty($lastValidateAction) ? $lastValidateAction[0]->datec : 0); |
There was a problem hiding this comment.
dernière condition du ternaire met un '' plutot que 0
| $lastReOpenDate = (is_array($lastValidateAction) && !empty($lastValidateAction) ? $lastReOpenAction[0]->datec : 0); | ||
|
|
||
| print '<td class="' . $resource['css'] . '">'; | ||
| print $lastValidateDate > 0 ? $langs->trans('ValidationDate') . ': <br>' . dol_print_date($lastValidateDate, 'dayhour') . '<br>' : ''; |
There was a problem hiding this comment.
ici check sur dol_strlen vu que c'est une string, c'est plus clean que > 0
| print '<td class="' . $resource['css'] . '">'; | ||
| print $lastValidateDate > 0 ? $langs->trans('ValidationDate') . ': <br>' . dol_print_date($lastValidateDate, 'dayhour') . '<br>' : ''; | ||
| print $lastReOpenDate > 0 ? $langs->trans('ReOpenDate') . ': <br>' . dol_print_date($lastReOpenDate, 'dayhour') . '<br>' : ''; | ||
| print '</td>'; | ||
| } else { |
There was a problem hiding this comment.
ca fait mal de voir un doublon de cette taille là y a pas moyen de merger survey_list et control_list ?
evarisk-micka
force-pushed
the
add_infos_on_list
branch
from
fd56108 to
6f572d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.