Adds the ability to have per item transaction permissions & applies enchantment permissions to signs #5976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added per-item-transaction-permissions and enchant-sign-restrictions to config file. When true, it requires users to have specific commands to enchant or to buy and sell. Enchant sign tweaked a bit to make it auto adjust.
NicholasJBond
force-pushed
the
issues/2212
branch
from
9956098 to
1a0d103
Compare
NicholasJBond
changed the title
merenze
reviewed
Mar 4, 2025
| @@ -97,6 +97,7 @@ burnCommandDescription=Set a player on fire. | |||
| burnCommandUsage=/<command> <player> <seconds> | |||
| burnCommandUsage1Description=Sets the specified player on fire for the specified amount of seconds | |||
| burnMsg=<primary>You set<secondary> {0} <primary>on fire for<secondary> {1} seconds<primary>. | |||
| buySpecificItemPermission=<primary>You do not have permission to buy <Secondary>{0} | |||
There was a problem hiding this comment.
Suggested change
| buySpecificItemPermission=<primary>You do not have permission to buy <Secondary>{0} | |
| buySpecificItemPermission=<primary>You do not have permission to buy <secondary>{0} |
| @@ -375,6 +376,7 @@ flyCommandUsage1Description=Toggles fly for yourself or another player if specif | |||
| flying=flying | |||
| flyMode=<primary>Set fly mode<secondary> {0} <primary>for {1}<primary>. | |||
| foreverAlone=<dark_red>You have nobody to whom you can reply. | |||
| freeSpecificItemPermission=<primary>You do not have permission to accept the free offer of <Secondary>{0} | |||
There was a problem hiding this comment.
Suggested change
| freeSpecificItemPermission=<primary>You do not have permission to accept the free offer of <Secondary>{0} | |
| freeSpecificItemPermission=<primary>You do not have permission to accept the free offer of <secondary>{0} |
| @@ -980,6 +982,7 @@ sellCommandUsage3Description=Sells all possible items in your inventory | |||
| sellCommandUsage4=/<command> blocks [amount] | |||
| sellCommandUsage4Description=Sells all (or the given amount, if specified) of blocks in your inventory | |||
| sellHandPermission=<primary>You do not have permission to hand sell. | |||
| sellSpecificItemPermission=<primary>You do not have permission to sell <Secondary>{0} | |||
There was a problem hiding this comment.
Suggested change
| sellSpecificItemPermission=<primary>You do not have permission to sell <Secondary>{0} | |
| sellSpecificItemPermission=<primary>You do not have permission to sell <secondary>{0} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Information
This PR fixes #2212.
Follow up of PR #5585.
Details
Proposed fix:
The command
/sell handand/sell blocksand a sell sign will require you to have the permission corresponding to the item in the formatessentials.item.<buy|sell|free>.<itemName>. Players still need the permissionsessentials.sell.<hand|inventory>andessentials.signs.<free|buy|sell>.usedepending on which method they sell their items.The same is required to use buy and free signs. Players will require the permission
essentials.item.<buy|sell|free>.<itemName>andessentials.signs.<free|buy|sell>.use. However there is no command for buy and free.To use an enchant sign, players will need the permission
essentials.enchantments.<enchantmentName>along withessentials.signs.enchant.use.These features are disabled by default and are configurable in the config.yml file as
per-item-transaction-permissionsandenchant-sign-restrictions.The enchant sign has also been updated to capitalise the first letter of the enchantment name and puts the currency symbol if not added by the player on creation of the sign.
Environments tested:
OS:
Windows
Java version:
21.0.
Demonstration: